daru/PICsense
Watch
1
0
Fork
You've already forked PICsense
 0
Code Issues 11 Pull requests Projects Releases Packages Wiki Activity Actions

bug: XC8 register bitfield accessors used incorrectly across codebase #29

New issue
Closed
opened 2026-08-02 05:25:20 +00:00 by time · 1 comment
time commented 2026-08-02 05:25:20 +00:00
Contributor
Copy link

The XC8 DFP header defines peripheral register bits as struct members (FVRCONbits.FVREN, etc.), not as #define constants. Code was using bare bitfield names as if they were C bit-position constants, which only compiled due to XC8 quirks but produced wrong register values. Affected: FVR (ADFVR gain=0, never ready), WDT (reserved prescaler → ~1ms instead of 256s), ADC (channel selection + GO_nDONE), comparator, CPS. Fix: use RegisterNamebits.FieldName pattern throughout.

The XC8 DFP header defines peripheral register bits as struct members (FVRCONbits.FVREN, etc.), not as #define constants. Code was using bare bitfield names as if they were C bit-position constants, which only compiled due to XC8 quirks but produced wrong register values. Affected: FVR (ADFVR gain=0, never ready), WDT (reserved prescaler → ~1ms instead of 256s), ADC (channel selection + GO_nDONE), comparator, CPS. Fix: use RegisterNamebits.FieldName pattern throughout.
time commented 2026-08-03 04:00:15 +00:00
Author
Contributor
Copy link

Fixed in PR #39: all peripheral register access now uses XC8 DFP bitfield accessors (e.g., FVRCONbits.FVREN instead of bare bitfield names).

Fixed in PR #39: all peripheral register access now uses XC8 DFP bitfield accessors (e.g., FVRCONbits.FVREN instead of bare bitfield names).
time closed this issue 2026-08-03 04:06:57 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
v0.1.0-hw
Labels
Clear labels   
bug
Something is not working

  
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
help wanted
Need some help

  
invalid
Something is wrong

  
question
More information is needed

  
wait-to-fix
Intentionally leaving the issue open until blockers are complete

  
wontfix
This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
wait-to-fix
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
daru/PICsense#29
No description provided.