daru/PICsense
Watch
1
0
Fork
You've already forked PICsense
 0
Code Issues 11 Pull requests Projects Releases Packages Wiki Activity Actions

bug: tx_done and tx_bit_idx missing volatile qualifier #32

New issue
Closed
opened 2026-08-02 05:25:20 +00:00 by time · 1 comment
time commented 2026-08-02 05:25:20 +00:00
Contributor
Copy link

tx_done is written in ISR and read in main, tx_bit_idx is written in main and read in ISR. Without volatile, compiler can cache these in registers, causing infinite loops in while(!tx_done) and stale reads in ISR. Fix: add volatile to both.

tx_done is written in ISR and read in main, tx_bit_idx is written in main and read in ISR. Without volatile, compiler can cache these in registers, causing infinite loops in while(!tx_done) and stale reads in ISR. Fix: add volatile to both.
time commented 2026-08-03 04:00:15 +00:00
Author
Contributor
Copy link

Fixed in PR #39: tx_done and tx_bit_idx removed entirely. Replaced with single volatile uint8_t tx_tick flag set by ISR, read by main loop.

Fixed in PR #39: tx_done and tx_bit_idx removed entirely. Replaced with single volatile uint8_t tx_tick flag set by ISR, read by main loop.
time closed this issue 2026-08-03 04:06:57 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
v0.1.0-hw
Labels
Clear labels   
bug
Something is not working

  
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
help wanted
Need some help

  
invalid
Something is wrong

  
question
More information is needed

  
wait-to-fix
Intentionally leaving the issue open until blockers are complete

  
wontfix
This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
wait-to-fix
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
daru/PICsense#32
No description provided.