daru/PICsense
Watch
1
0
Fork
You've already forked PICsense
 0
Code Issues 11 Pull requests Projects Releases Packages Wiki Activity Actions

bug: pin_write macro used undefined identifier LATA2, never actually toggled DATA pin #35

New issue
Closed
opened 2026-08-02 05:57:15 +00:00 by time · 1 comment
time commented 2026-08-02 05:57:15 +00:00
Contributor
Copy link

The CONCAT-based pin_write macro expanded CONCAT(LATA, 2) to LATA2, but LATA2 is not a defined identifier in the XC8 DFP — the correct name is LATAbits.LATA2. This meant pin_write wrote to an undefined variable, the DATA pin never actually toggled, and no RF energy was produced. Fixed with indirection-layer bitfield accessors.

The CONCAT-based pin_write macro expanded CONCAT(LATA, 2) to LATA2, but LATA2 is not a defined identifier in the XC8 DFP — the correct name is LATAbits.LATA2. This meant pin_write wrote to an undefined variable, the DATA pin never actually toggled, and no RF energy was produced. Fixed with indirection-layer bitfield accessors.
time commented 2026-08-03 04:00:15 +00:00
Author
Contributor
Copy link

Fixed in PR #39: pin_write macros rewritten with indirection layer (_pin_write_impl → LATAbits.LATA##p) so CONCAT produces valid XC8 DFP identifiers.

Fixed in PR #39: pin_write macros rewritten with indirection layer (_pin_write_impl → LATAbits.LATA##p) so CONCAT produces valid XC8 DFP identifiers.
time closed this issue 2026-08-03 04:06:57 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
v0.1.0-hw
Labels
Clear labels   
bug
Something is not working

  
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
help wanted
Need some help

  
invalid
Something is wrong

  
question
More information is needed

  
wait-to-fix
Intentionally leaving the issue open until blockers are complete

  
wontfix
This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
wait-to-fix
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
daru/PICsense#35
No description provided.