daru/PICsense
Watch
1
0
Fork
You've already forked PICsense
 0
Code Issues 11 Pull requests Projects Releases Packages Wiki Activity Actions

fix: remove dead preamble pre-load in build_packet #14

Merged
daru merged 1 commit from fix/dead-preamble-preload into main 2026-07-26 22:39:26 +00:00
Conversation 0 Commits 1 Files changed 1 -5
time commented 2026-07-26 22:38:07 +00:00
Contributor
Copy link

Removes 5 lines of dead code: dst_buffer[0] and dst_buffer[1] were pre-loaded with preamble bytes, but manchester_encode overwrites them with the encoded raw array which already contains the preamble.

Fixes #6

Removes 5 lines of dead code: dst_buffer[0] and dst_buffer[1] were pre-loaded with preamble bytes, but manchester_encode overwrites them with the encoded raw array which already contains the preamble. Fixes #6
build_packet pre-loads dst_buffer[0]=0x0056 and dst_buffer[1]=0x655a, but
manchester_encode then writes the full raw array (which already contains the
preamble) starting at dst_buffer[0], overwriting both values. The pre-load
is dead code.
daru merged commit 6d7c5655ca into main 2026-07-26 22:39:26 +00:00
daru deleted branch fix/dead-preamble-preload 2026-07-26 22:39:35 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug
Something is not working

  
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
help wanted
Need some help

  
invalid
Something is wrong

  
question
More information is needed

  
wait-to-fix
Intentionally leaving the issue open until blockers are complete

  
wontfix
This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
wait-to-fix
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
daru/PICsense!14
No description provided.