dead code: build_packet pre-loads preamble that gets overwritten #6

New issue

Closed

opened 2026-07-26 17:02:22 +00:00 by daru · 1 comment

daru commented

2026-07-26 17:02:22 +00:00

Owner

build_packet sets dst_buffer[0]=0x0056, dst_buffer[1]=0x655a, then manchester_encode writes the full raw array starting at dst[0], overwriting both. The pre-load is dead code.

Fix: remove the dead pre-load lines.

build_packet sets dst_buffer[0]=0x0056, dst_buffer[1]=0x655a, then manchester_encode writes the full raw array starting at dst[0], overwriting both. The pre-load is dead code. Fix: remove the dead pre-load lines.

time referenced this issue from a pull request that will close it,

2026-07-26 22:38:07 +00:00

fix: remove dead preamble pre-load in build_packet #14

time commented

2026-07-26 22:38:12 +00:00

Contributor

Fixed in PR #14: removed the 3 dead lines (dst_buffer[0]=0x0056, dst_buffer[1]=0x655a) — manchester_encode overwrites them anyway since raw[] already contains the preamble.

daru closed this issue

2026-07-26 22:39:26 +00:00