start_fvr_tmp_adc return value discarded - FVR timeout unhandled #4

New issue

Closed

opened 2026-07-26 17:01:58 +00:00 by daru · 2 comments

daru commented

2026-07-26 17:01:58 +00:00

Owner

start_fvr_tmp_adc returns 0 on success, 1 on FVR timeout, but main.c discards the return value. If FVR fails to stabilize, ADC readings will be garbage.

Fix: check return value and handle timeout case.

start_fvr_tmp_adc returns 0 on success, 1 on FVR timeout, but main.c discards the return value. If FVR fails to stabilize, ADC readings will be garbage. Fix: check return value and handle timeout case.

time referenced this issue from a pull request that will close it,

2026-07-27 02:15:19 +00:00

fix: check start_fvr_tmp_adc return value on FVR timeout #21

time commented

2026-07-27 02:15:19 +00:00

Contributor

Fixed in PR #21: check return value of start_fvr_tmp_adc, skip transmission cycle if FVR fails to stabilize.

Fixed in PR #21: check return value of `start_fvr_tmp_adc`, skip transmission cycle if FVR fails to stabilize.

daru closed this issue

2026-07-27 02:22:53 +00:00

time commented

2026-07-27 02:33:57 +00:00

Contributor

Updated PR #21: instead of skipping transmission on FVR timeout, now sets bit 15 of TX_STATUS and continues transmitting. Decoder extracts this flag and reports fvr_error=1 with temp=-999.0°C.