fix: check start_fvr_tmp_adc return value on FVR timeout #21

Merged

daru merged 3 commits from fix/fvr_timeout_unhandled into main

2026-07-27 03:24:19 +00:00

time commented

2026-07-27 02:15:19 +00:00

Contributor

Fixes #4

start_fvr_tmp_adc returns 1 if FVR fails to stabilize within the timeout period. Previously the return value was discarded, meaning ADC readings would be garbage if FVR failed.

Now the return value is checked and the transmission cycle is skipped if FVR fails, preventing garbage data from being transmitted.

Fixes #4 `start_fvr_tmp_adc` returns 1 if FVR fails to stabilize within the timeout period. Previously the return value was discarded, meaning ADC readings would be garbage if FVR failed. Now the return value is checked and the transmission cycle is skipped if FVR fails, preventing garbage data from being transmitted.

time added 1 commit

2026-07-27 02:15:19 +00:00

fix: check start_fvr_tmp_adc return value - skip cycle on FVR timeout d57e57b054

start_fvr_tmp_adc returns 1 if FVR fails to stabilize within the timeout
period. Previously the return value was discarded, meaning ADC readings
would be garbage if FVR failed. Now the return value is checked and the
transmission cycle is skipped if FVR fails, preventing garbage data from
being transmitted.

time referenced this pull request

2026-07-27 02:15:19 +00:00

start_fvr_tmp_adc return value discarded - FVR timeout unhandled #4

daru requested changes

2026-07-27 02:21:27 +00:00

daru left a comment

Makes sense, don't transmit stale data, but I think I would prefer to send an error field of some sort, rather than to not transmit at all. Might need a change in transmit schema and in decoding on rtl_433.